ppc: Fix return of instruction handlers in ppc_process_record_op63

some instruction handlers in ppc_process_record_op63() seem to be missing
return or incorrectly using break. This patch aims to fix that.

gdb/ChangeLog:
2016-09-21  Edjunior Barbosa Machado  <[email protected]>

	* rs6000-tdep.c (ppc_process_record_op63): Fix return of instruction
	handlers.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 6753ebe4609d94185e4bd1a1b0769229dd3baf63..4ee67fb4c6808697fdcd7ca6e309afc2a7a4c379 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2016-09-21  Edjunior Barbosa Machado  <[email protected]>
+
+       * rs6000-tdep.c (ppc_process_record_op63): Fix return of instruction
+       handlers.
+
 2016-09-21  Tom Tromey  <[email protected]>
 
        PR gdb/20604:

diff --git a/gdb/rs6000-tdep.c b/gdb/rs6000-tdep.c
index d7cf38f8be0a9c801643f978931408901a17e493..1add49897f8b04fa51241153febb63b96ea9b31d 100644 (file)
--- a/gdb/rs6000-tdep.c
+++ b/gdb/rs6000-tdep.c
@@ -5399,6 +5399,7 @@ ppc_process_record_op63 (struct gdbarch *gdbarch, struct regcache *regcache,
                                     tdep->ppc_fp0_regnum + PPC_FRT (insn));
       if (PPC_RC (insn))
        record_full_arch_list_add_reg (regcache, tdep->ppc_cr_regnum);
+      return 0;
     }
 
   switch (ext & 0xff)
@@ -5462,7 +5463,7 @@ ppc_process_record_op63 (struct gdbarch *gdbarch, struct regcache *regcache,
       if (PPC_RC (insn))
        record_full_arch_list_add_reg (regcache, tdep->ppc_cr_regnum);
       record_full_arch_list_add_reg (regcache, tdep->ppc_fpscr_regnum);
-      break;
+      return 0;
 
     case 354:          /* DFP Extract Biased Exponent Quad */
       record_full_arch_list_add_reg (regcache,
@@ -5541,7 +5542,7 @@ ppc_process_record_op63 (struct gdbarch *gdbarch, struct regcache *regcache,
       if (PPC_RC (insn))
        record_full_arch_list_add_reg (regcache, tdep->ppc_cr_regnum);
       record_full_arch_list_add_reg (regcache, tdep->ppc_fpscr_regnum);
-      break;
+      return 0;
 
     case 0:            /* Floating Compare Unordered */
     case 32:           /* Floating Compare Ordered */