pwm: Fix double shift bug

These enums are passed to set/test_bit().  The set/test_bit() functions
take a bit number instead of a shifted value.  Passing a shifted value
is a double shift bug like doing BIT(BIT(1)).  The double shift bug
doesn't cause a problem here because we are only checking 0 and 1 but
if the value was 5 or above then it can lead to a buffer overflow.

Signed-off-by: Dan Carpenter <[email protected]>
Reviewed-by: Uwe Kleine-König <[email protected]>
Reviewed-by: Sam Protsenko <[email protected]>
Signed-off-by: Thierry Reding <[email protected]>

diff --git a/include/linux/pwm.h b/include/linux/pwm.h
index e3b437587b32d7d84d5f367d6643b3c1fa1ce702..cda3597b84f2c32fbe567c04b3c4114311bed02a 100644 (file)
--- a/include/linux/pwm.h
+++ b/include/linux/pwm.h
@@ -41,8 +41,8 @@ struct pwm_args {
 };
 
 enum {
-       PWMF_REQUESTED = 1 << 0,
-       PWMF_EXPORTED = 1 << 1,
+       PWMF_REQUESTED = 0,
+       PWMF_EXPORTED = 1,
 };
 
 /*