]> Git Repo - u-boot.git/commitdiff
fs/squashfs: fix sqfs_read_sblk()
authorHeinrich Schuchardt <[email protected]>
Tue, 10 May 2022 19:53:25 +0000 (21:53 +0200)
committerTom Rini <[email protected]>
Mon, 6 Jun 2022 21:47:17 +0000 (17:47 -0400)
Setting sblk = NULL has no effect on the caller.
We want to set *sblk = NULL if an error occurrs to avoid usage after free.

Signed-off-by: Heinrich Schuchardt <[email protected]>
fs/squashfs/sqfs.c

index 547d2fd4b3025d251232d27858238bc8fea0a584..90bf32ca0ae5594337b766ae4fbde1f599e07511 100644 (file)
@@ -49,7 +49,7 @@ static int sqfs_read_sblk(struct squashfs_super_block **sblk)
 
        if (sqfs_disk_read(0, 1, *sblk) != 1) {
                free(*sblk);
-               sblk = NULL;
+               *sblk = NULL;
                return -EINVAL;
        }
 
This page took 0.037485 seconds and 4 git commands to generate.