]> Git Repo - secp256k1.git/commit
Merge #648: Prevent ints from wrapping around in scratch space functions
authorTim Ruffing <[email protected]>
Wed, 2 Sep 2020 00:19:16 +0000 (02:19 +0200)
committerTim Ruffing <[email protected]>
Wed, 2 Sep 2020 00:20:32 +0000 (02:20 +0200)
commitaabf00c1553ff7cf46aecabf2d0e45981fc54a76
treebabbafa768d6dc2aaa52dd731c7c050a353156df
parentf5adab16a9495f3f8ec1d981645e9943e7bd96f9
parent60f7f2de5de917c2bee32a4cd79cc3818b6a94a0
Merge #648: Prevent ints from wrapping around in scratch space functions

60f7f2de5de917c2bee32a4cd79cc3818b6a94a0 Don't assume that ALIGNMENT > 1 in tests (Tim Ruffing)
ada6361dece4265823478e0019a8c196e9285a26 Use ROUND_TO_ALIGN in scratch_create (Jonas Nick)
8ecc6ce50ead28a0b8bab2f1fb18a58ee5204a13 Add check preventing rounding to alignment from wrapping around in scratch_alloc (Jonas Nick)
4edaf06fb02a9ac9cd115e0c967bb0ef35cae01d Add check preventing integer multiplication wrapping around in scratch_max_allocation (Jonas Nick)

Pull request description:

  This PR increases the general robustness of scratch spaces. It does not fix an existing vulnerability because scratch spaces aren't used anywhere in master. Additionally,  it must be prevented anyway that an attacker has (indirect) control over the arguments touched in this PR.

ACKs for top commit:
  sipa:
    ACK 60f7f2de5de917c2bee32a4cd79cc3818b6a94a0

Tree-SHA512: ecdd794b55a01d1d6d24098f3abff34cb8bb6f33737ec4ec93714aa631c9d397b213cc3603a916ad79f4b09d6b2f8973bf87fc07b81b25a530cc72c4dbafaba9
src/tests.c
This page took 0.024236 seconds and 4 git commands to generate.