qapi: ensure stable sort ordering when checking QAPI entities

Some early python 3.x versions will have different default
ordering when calling the 'values()' method on a dict, compared
to python 2.x and later 3.x versions. Explicitly sort the items
to get a stable ordering.

Reviewed-by: Philippe Mathieu-Daudé <[email protected]>
Signed-off-by: Daniel P. Berrange <[email protected]>
Message-Id: <20180116134217[email protected]>
Signed-off-by: Eduardo Habkost <[email protected]>

diff --git a/scripts/qapi.py b/scripts/qapi.py
index 1fdd189c0da47d265432c6edc39f9dde9cce9208..58f995b07fd23299d1becf10b3165b0070c7fed7 100644 (file)
--- a/scripts/qapi.py
+++ b/scripts/qapi.py
@@ -1678,7 +1678,7 @@ class QAPISchema(object):
                 assert False
 
     def check(self):
-        for ent in self._entity_dict.values():
+        for (name, ent) in sorted(self._entity_dict.items()):
             ent.check(self)
 
     def visit(self, visitor):