iscsi: fix missing unlock

Reported by Coverity.

Signed-off-by: Paolo Bonzini <[email protected]>

diff --git a/block/iscsi.c b/block/iscsi.c
index 76319a1a6eadc34132aef4bd3d583e5f35f17d17..75d890538e4b39629ac07a39474c204cbe90eb1c 100644 (file)
--- a/block/iscsi.c
+++ b/block/iscsi.c
@@ -637,6 +637,7 @@ retry:
     }
 #endif
     if (iTask.task == NULL) {
     }
 #endif
     if (iTask.task == NULL) {

+        qemu_mutex_unlock(&iscsilun->mutex);

         return -ENOMEM;
     }
 #if LIBISCSI_API_VERSION < (20160603)
         return -ENOMEM;
     }
 #if LIBISCSI_API_VERSION < (20160603)


@@ -864,6 +865,7 @@ retry:
     }
 #endif
     if (iTask.task == NULL) {
     }
 #endif
     if (iTask.task == NULL) {

+        qemu_mutex_unlock(&iscsilun->mutex);

         return -ENOMEM;
     }
 #if LIBISCSI_API_VERSION < (20160603)
         return -ENOMEM;
     }
 #if LIBISCSI_API_VERSION < (20160603)


@@ -904,6 +906,7 @@ static int coroutine_fn iscsi_co_flush(BlockDriverState *bs)
 retry:
     if (iscsi_synchronizecache10_task(iscsilun->iscsi, iscsilun->lun, 0, 0, 0,
                                       0, iscsi_co_generic_cb, &iTask) == NULL) {
 retry:
     if (iscsi_synchronizecache10_task(iscsilun->iscsi, iscsilun->lun, 0, 0, 0,
                                       0, iscsi_co_generic_cb, &iTask) == NULL) {

+        qemu_mutex_unlock(&iscsilun->mutex);

         return -ENOMEM;
     }
 
         return -ENOMEM;
     }
 


@@ -1237,6 +1240,7 @@ retry:
                                             0, 0, iscsi_co_generic_cb, &iTask);
     }
     if (iTask.task == NULL) {
                                             0, 0, iscsi_co_generic_cb, &iTask);
     }
     if (iTask.task == NULL) {

+        qemu_mutex_unlock(&iscsilun->mutex);

         return -ENOMEM;
     }
 
         return -ENOMEM;
     }