scripts/checkpatch.pl: Detect superfluous semicolon in C code

Display error when a commit contains superfluous semicolon:

  $ git show 6663a0a3376 | scripts/checkpatch.pl -q -
  ERROR: superfluous trailing semicolon
  #276: FILE: block/io_uring.c:186:
  +                ret = -ENOSPC;;
  total: 1 errors, 1 warnings, 485 lines checked

Reported-by: Luc Michel <[email protected]>
Signed-off-by: Philippe Mathieu-Daudé <[email protected]>
Acked-by: Paolo Bonzini <[email protected]>
Reviewed-by: Dr. David Alan Gilbert <[email protected]>
Reviewed-by: Juan Quintela <[email protected]>
Reviewed-by: Luc Michel <[email protected]>
Message-Id: <20200218094402[email protected]>
Signed-off-by: Laurent Vivier <[email protected]>

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index ce43a306f867462b39e99aacca29429adc37c4fa..11512a8a09b84001eedc881034cd5612c7f9225c 100755 (executable)
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -1830,6 +1830,11 @@ sub process {
                        ERROR("suspicious ; after while (0)\n" . $herecurr);
                }
 
+# Check superfluous trailing ';'
+               if ($line =~ /;;$/) {
+                       ERROR("superfluous trailing semicolon\n" . $herecurr);
+               }
+
 # Check relative indent for conditionals and blocks.
                if ($line =~ /\b(?:(?:if|while|for)\s*\(|do\b)/ && $line !~ /^.\s*#/ && $line !~ /\}\s*while\s*/) {
                        my ($s, $c) = ($stat, $cond);