chardev/tcp: Fix error message double free error

Errors are already freed by error_report_err, so we only need to call
error_free when that function is not called.

Cc: [email protected]
Signed-off-by: lichun <[email protected]>
Message-Id: <20200621213017[email protected]>
Reviewed-by: Markus Armbruster <[email protected]>
[Commit message improved, cc: qemu-stable]
Signed-off-by: Markus Armbruster <[email protected]>

diff --git a/chardev/char-socket.c b/chardev/char-socket.c
index afebeec5c368889e1de61e7877dda5d77fe22554..569d54c144bee760753bb19bd79ec893188f2da9 100644 (file)
--- a/chardev/char-socket.c
+++ b/chardev/char-socket.c
@@ -142,6 +142,8 @@ static void check_report_connect_error(Chardev *chr,
                           "Unable to connect character device %s: ",
                           chr->label);
         s->connect_err_reported = true;
+    } else {
+        error_free(err);
     }
     qemu_chr_socket_restart_timer(chr);
 }
@@ -1086,7 +1088,6 @@ static void qemu_chr_socket_connected(QIOTask *task, void *opaque)
     if (qio_task_propagate_error(task, &err)) {
         tcp_chr_change_state(s, TCP_CHARDEV_STATE_DISCONNECTED);
         check_report_connect_error(chr, err);
-        error_free(err);
         goto cleanup;
     }