]> Git Repo - qemu.git/commitdiff
Endian fix an assertion in usb-msd
authorBenjamin Herrenschmidt <[email protected]>
Thu, 8 Mar 2012 00:41:10 +0000 (11:41 +1100)
committerGerd Hoffmann <[email protected]>
Tue, 13 Mar 2012 09:52:25 +0000 (10:52 +0100)
This fixes a broken endian assumption in an assertion in usb-msd.

Cc: Gerd Hoffman <[email protected]>
Signed-off-by: Benjamin Herrenschmidt <[email protected]>
Signed-off-by: David Gibson <[email protected]>
Signed-off-by: Gerd Hoffmann <[email protected]>
hw/usb/dev-storage.c

index 6ffaf7066196a0f40f10a08b5a8c84e187791dbf..bdbe7bdd113c67d7d7679069d51329c39d3199df 100644 (file)
@@ -193,9 +193,9 @@ static void usb_msd_send_status(MSDState *s, USBPacket *p)
     int len;
 
     DPRINTF("Command status %d tag 0x%x, len %zd\n",
-            s->csw.status, s->csw.tag, p->iov.size);
+            s->csw.status, le32_to_cpu(s->csw.tag), p->iov.size);
 
-    assert(s->csw.sig == 0x53425355);
+    assert(s->csw.sig == cpu_to_le32(0x53425355));
     len = MIN(sizeof(s->csw), p->iov.size);
     usb_packet_copy(p, &s->csw, len);
     memset(&s->csw, 0, sizeof(s->csw));
@@ -233,7 +233,7 @@ static void usb_msd_command_complete(SCSIRequest *req, uint32_t status, size_t r
 
     s->csw.sig = cpu_to_le32(0x53425355);
     s->csw.tag = cpu_to_le32(req->tag);
-    s->csw.residue = s->residue;
+    s->csw.residue = cpu_to_le32(s->residue);
     s->csw.status = status != 0;
 
     if (s->packet) {
This page took 0.02875 seconds and 4 git commands to generate.