]> Git Repo - qemu.git/commitdiff
target-i386: Filter FEAT_7_0_EBX TCG features too
authorEduardo Habkost <[email protected]>
Wed, 30 Apr 2014 16:48:34 +0000 (13:48 -0300)
committerAndreas Färber <[email protected]>
Wed, 25 Jun 2014 21:54:29 +0000 (23:54 +0200)
The TCG_7_0_EBX_FEATURES macro was defined but never used (it even had a
typo that was never noticed). Make the existing TCG feature filtering
code use it.

Reviewed-by: Richard Henderson <[email protected]>
Signed-off-by: Eduardo Habkost <[email protected]>
Cc: [email protected]
Signed-off-by: Andreas Färber <[email protected]>
target-i386/cpu.c

index 27666c7749c536c83a12e03ec29c084bf603efa2..077df27b4b2b417828d6ff7db322ee86e512d1e4 100644 (file)
@@ -586,7 +586,7 @@ struct X86CPUDefinition {
 #define TCG_EXT3_FEATURES (CPUID_EXT3_LAHF_LM | CPUID_EXT3_SVM | \
           CPUID_EXT3_CR8LEG | CPUID_EXT3_ABM | CPUID_EXT3_SSE4A)
 #define TCG_SVM_FEATURES 0
-#define TCG_7_0_EBX_FEATURES (CPUID_7_0_EBX_SMEP | CPUID_7_0_EBX_SMAP \
+#define TCG_7_0_EBX_FEATURES (CPUID_7_0_EBX_SMEP | CPUID_7_0_EBX_SMAP \
           CPUID_7_0_EBX_BMI1 | CPUID_7_0_EBX_BMI2 | CPUID_7_0_EBX_ADX)
           /* missing:
           CPUID_7_0_EBX_FSGSBASE, CPUID_7_0_EBX_HLE, CPUID_7_0_EBX_AVX2,
@@ -2602,6 +2602,7 @@ static void x86_cpu_realizefn(DeviceState *dev, Error **errp)
     if (!kvm_enabled()) {
         env->features[FEAT_1_EDX] &= TCG_FEATURES;
         env->features[FEAT_1_ECX] &= TCG_EXT_FEATURES;
+        env->features[FEAT_7_0_EBX] &= TCG_7_0_EBX_FEATURES;
         env->features[FEAT_8000_0001_EDX] &= TCG_EXT2_FEATURES;
         env->features[FEAT_8000_0001_ECX] &= TCG_EXT3_FEATURES;
         env->features[FEAT_SVM] &= TCG_SVM_FEATURES;
This page took 0.029203 seconds and 4 git commands to generate.