qemu-img: fix img_commit() error return value

The img_commit() return value is a process exit code.  Use 1 for failure
instead of -1.  The other failure paths in this function already use 1.

Signed-off-by: Stefan Hajnoczi <[email protected]>
Reviewed-by: Max Reitz <[email protected]>

diff --git a/qemu-img.c b/qemu-img.c
index 2052b14b843b4242a002aa4c28ce4d8a7758233e..863798e54b58d911e00c6d5484da73a65543529a 100644 (file)
--- a/qemu-img.c
+++ b/qemu-img.c
@@ -752,7 +752,7 @@ static int img_commit(int argc, char **argv)
     ret = bdrv_parse_cache_flags(cache, &flags);
     if (ret < 0) {
         error_report("Invalid cache option: %s", cache);
     ret = bdrv_parse_cache_flags(cache, &flags);
     if (ret < 0) {
         error_report("Invalid cache option: %s", cache);

-        return -1;
+        return 1;

     }
 
     bs = bdrv_new_open("image", filename, fmt, flags, true, quiet);
     }
 
     bs = bdrv_new_open("image", filename, fmt, flags, true, quiet);