block/nfs: fix NULL pointer dereference in URI parsing

parse_uint_full wants to put the parsed value into the
variable passed via its second argument which is NULL.

Fixes: 94d6a7a76e9df9919629428f6c598e2b97d9426c
Cc: [email protected]
Signed-off-by: Peter Lieven <[email protected]>
Reviewed-by: Eric Blake <[email protected]>
Message-id: 1485942829[email protected]
Signed-off-by: Max Reitz <[email protected]>

diff --git a/block/nfs.c b/block/nfs.c
index a564340d1584500509f6139329b8daf1b92e3a7e..baaecff3fd291fac5aac90a4043d42bb6468ff51 100644 (file)
--- a/block/nfs.c
+++ b/block/nfs.c
@@ -108,12 +108,13 @@ static int nfs_parse_uri(const char *filename, QDict *options, Error **errp)
     qdict_put(options, "path", qstring_from_str(uri->path));
 
     for (i = 0; i < qp->n; i++) {
+        unsigned long long val;
         if (!qp->p[i].value) {
             error_setg(errp, "Value for NFS parameter expected: %s",
                        qp->p[i].name);
             goto out;
         }
-        if (parse_uint_full(qp->p[i].value, NULL, 0)) {
+        if (parse_uint_full(qp->p[i].value, &val, 0)) {
             error_setg(errp, "Illegal value for NFS parameter: %s",
                        qp->p[i].name);
             goto out;