]> Git Repo - qemu.git/commitdiff
linux-user: init_guest_space: Add a comment about search strategy
authorLuke Shumaker <[email protected]>
Thu, 28 Dec 2017 18:08:12 +0000 (13:08 -0500)
committerLaurent Vivier <[email protected]>
Tue, 13 Mar 2018 14:04:01 +0000 (15:04 +0100)
Signed-off-by: Luke Shumaker <[email protected]>
Message-Id: <20171228180814[email protected]>
Reviewed-by: Peter Maydell <[email protected]>
Signed-off-by: Laurent Vivier <[email protected]>
linux-user/elfload.c

index 5c64299961d296d68ba97cb28b08590db641671b..9d10a5f5924ef9707ed022886cc5714515a0ca92 100644 (file)
@@ -1910,6 +1910,10 @@ unsigned long init_guest_space(unsigned long host_start,
          * happen often.  Probably means we got unlucky and host
          * address space randomization put a shared library somewhere
          * inconvenient.
+         *
+         * This is probably a good strategy if host_start, but is
+         * probably a bad strategy if not, which means we got here
+         * because of trouble with ARM commpage setup.
          */
         munmap((void *)real_start, real_size);
         current_start += qemu_host_page_size;
This page took 0.030413 seconds and 4 git commands to generate.