slirp: goto bad in udp_input if sosendto fails

Before this patch, if sosendto fails, udp_input is executed as if the
packet was sent, recording the packet for icmp errors, which does not
makes sense since the packet was not actually sent, errors would be
related to a previous packet.

This patch adds a goto bad to cut the execution of this function.

Signed-off-by: Guillaume Subiron <[email protected]>
Signed-off-by: Samuel Thibault <[email protected]>
Reviewed-by: Thomas Huth <[email protected]>
Signed-off-by: Jason Wang <[email protected]>

diff --git a/slirp/udp.c b/slirp/udp.c
index fee13b4dbda1ab6f55de9a063b349f1c6e462911..ce63414c81bea574e91a821807ae0d665534b112 100644 (file)
--- a/slirp/udp.c
+++ b/slirp/udp.c
@@ -218,6 +218,7 @@ udp_input(register struct mbuf *m, int iphlen)
          *ip=save_ip;
          DEBUG_MISC((dfd,"udp tx errno = %d-%s\n",errno,strerror(errno)));
          icmp_error(m, ICMP_UNREACH,ICMP_UNREACH_NET, 0,strerror(errno));
          *ip=save_ip;
          DEBUG_MISC((dfd,"udp tx errno = %d-%s\n",errno,strerror(errno)));
          icmp_error(m, ICMP_UNREACH,ICMP_UNREACH_NET, 0,strerror(errno));

+         goto bad;

        }
 
        m_free(so->so_m);   /* used for ICMP if error on sorecvfrom */
        }
 
        m_free(so->so_m);   /* used for ICMP if error on sorecvfrom */