serial: fix memory leak in serial exit

The serial_exit_core function doesn't free some resources.
This can lead memory leak when hotplug and unplug. This
patch avoid this.

Signed-off-by: Li Qiang <[email protected]>
Message-Id: <586cb5ab.f31d9d0a[email protected]>
Signed-off-by: Paolo Bonzini <[email protected]>

diff --git a/hw/char/serial.c b/hw/char/serial.c
index ffbacd822708ea474bcd9a29d1678c7f3ee715f5..67b18eda125d154afbbfb7eb89728db98016b5fd 100644 (file)
--- a/hw/char/serial.c
+++ b/hw/char/serial.c
@@ -906,6 +906,16 @@ void serial_realize_core(SerialState *s, Error **errp)
 void serial_exit_core(SerialState *s)
 {
     qemu_chr_fe_deinit(&s->chr);
+
+    timer_del(s->modem_status_poll);
+    timer_free(s->modem_status_poll);
+
+    timer_del(s->fifo_timeout_timer);
+    timer_free(s->fifo_timeout_timer);
+
+    fifo8_destroy(&s->recv_fifo);
+    fifo8_destroy(&s->xmit_fifo);
+
     qemu_unregister_reset(serial_reset, s);
 }