]> Git Repo - qemu.git/commitdiff
savevm: Remove dead code in save_snapshot()
authorTuguoyi <[email protected]>
Tue, 8 Dec 2020 06:53:35 +0000 (14:53 +0800)
committerDr. David Alan Gilbert <[email protected]>
Fri, 18 Dec 2020 10:08:24 +0000 (10:08 +0000)
The snapshot in each bs is deleted at the beginning, so there is no need
to find the snapshot again.

Signed-off-by: Tuguoyi <[email protected]>
Message-Id: <1607410416[email protected]>
Reviewed-by: Denis V. Lunev <[email protected]>
Signed-off-by: Dr. David Alan Gilbert <[email protected]>
migration/savevm.c

index 5f937a2762793f2cc48bcd40a42369a9f60858c4..601b5144b85e45481d4a5499fd8ac0eeb4a46eb7 100644 (file)
@@ -2728,7 +2728,7 @@ int qemu_load_device_state(QEMUFile *f)
 int save_snapshot(const char *name, Error **errp)
 {
     BlockDriverState *bs, *bs1;
-    QEMUSnapshotInfo sn1, *sn = &sn1, old_sn1, *old_sn = &old_sn1;
+    QEMUSnapshotInfo sn1, *sn = &sn1;
     int ret = -1, ret2;
     QEMUFile *f;
     int saved_vm_running;
@@ -2797,13 +2797,7 @@ int save_snapshot(const char *name, Error **errp)
     }
 
     if (name) {
-        ret = bdrv_snapshot_find(bs, old_sn, name);
-        if (ret >= 0) {
-            pstrcpy(sn->name, sizeof(sn->name), old_sn->name);
-            pstrcpy(sn->id_str, sizeof(sn->id_str), old_sn->id_str);
-        } else {
-            pstrcpy(sn->name, sizeof(sn->name), name);
-        }
+        pstrcpy(sn->name, sizeof(sn->name), name);
     } else {
         /* cast below needed for OpenBSD where tv_sec is still 'long' */
         localtime_r((const time_t *)&tv.tv_sec, &tm);
This page took 0.029055 seconds and 4 git commands to generate.