spice: set qxl->ssd.running=true before telling spice to start, RHBZ #733993

If qxl->ssd.running=true is set after telling spice to start, the spice server
thread can call qxl_send_events while qxl->ssd.running is still false. This leads to
assert(d->ssd.running).

Signed-off-by: Yonit Halperin <[email protected]>
Signed-off-by: Gerd Hoffmann <[email protected]>

diff --git a/ui/spice-display.c b/ui/spice-display.c
index 498396332cd2a180a100a51e10ef173d599e05ec..e38536114b7ef838ea28c52c6c52e225a3577d8a 100644 (file)
--- a/ui/spice-display.c
+++ b/ui/spice-display.c
@@ -260,11 +260,12 @@ void qemu_spice_vm_change_state_handler(void *opaque, int running, int reason)
     SimpleSpiceDisplay *ssd = opaque;
 
     if (running) {
+        ssd->running = true;
         qemu_spice_start(ssd);
     } else {
         qemu_spice_stop(ssd);
+        ssd->running = false;
     }
-    ssd->running = running;
 }
 
 void qemu_spice_display_init_common(SimpleSpiceDisplay *ssd, DisplayState *ds)