]> Git Repo - qemu.git/commitdiff
hw: Default -drive to if=none instead of scsi when scsi cannot work
authorMarkus Armbruster <[email protected]>
Wed, 15 Feb 2017 10:05:43 +0000 (11:05 +0100)
committerMarkus Armbruster <[email protected]>
Tue, 21 Feb 2017 12:10:53 +0000 (13:10 +0100)
Block backends defined with -drive if=scsi are meant to be picked up
by machine initialization code: a suitable frontend gets created and
wired up automatically.

if=scsi drives not picked up that way can still be used with -device
as if they had if=none, but that's unclean and best avoided.  Unused
ones produce an "Orphaned drive without device" warning.

A few machine types default to if=scsi, even though they don't
actually have a SCSI HBA.  This makes no sense.  Change their default
to if=none.  Affected machines:

* aarch64/arm: realview-pbx-a9 vexpress-a9 vexpress-a15 xilinx-zynq-a9

Cc: Peter Maydell <[email protected]>
Cc: "Edgar E. Iglesias" <[email protected]>
Cc: Alistair Francis <[email protected]>
Cc: [email protected]
Signed-off-by: Markus Armbruster <[email protected]>
Reviewed-by: Thomas Huth <[email protected]>
Reviewed-by: Alistair Francis <[email protected]>
Message-Id: <1487153147[email protected]>

hw/arm/realview.c
hw/arm/vexpress.c
hw/arm/xilinx_zynq.c

index 8eafccaf1de81a13f5217af8cf3bbac0052a46a3..8c11c7ae777b44f8d5af493a4395740eed04a314 100644 (file)
@@ -443,7 +443,6 @@ static void realview_pbx_a9_class_init(ObjectClass *oc, void *data)
 
     mc->desc = "ARM RealView Platform Baseboard Explore for Cortex-A9";
     mc->init = realview_pbx_a9_init;
-    mc->block_default_type = IF_SCSI;
     mc->max_cpus = 4;
 }
 
index e05756846e8941dda97616448caaf67d8f4a4373..c6b1e674b469a333c68f1ee339851b20455f5f6e 100644 (file)
@@ -752,7 +752,6 @@ static void vexpress_class_init(ObjectClass *oc, void *data)
 
     mc->desc = "ARM Versatile Express";
     mc->init = vexpress_common_init;
-    mc->block_default_type = IF_SCSI;
     mc->max_cpus = 4;
 }
 
index 7dac20d67dcef879461fba9b12be11e56a57c646..3985356fc211a34f5b8563a527f964a731cd847c 100644 (file)
@@ -323,7 +323,6 @@ static void zynq_machine_init(MachineClass *mc)
 {
     mc->desc = "Xilinx Zynq Platform Baseboard for Cortex-A9";
     mc->init = zynq_init;
-    mc->block_default_type = IF_SCSI;
     mc->max_cpus = 1;
     mc->no_sdcard = 1;
 }
This page took 0.029862 seconds and 4 git commands to generate.