]> Git Repo - qemu.git/commitdiff
move 'unsafe' to end of caching modes in help
authorBruce Rogers <[email protected]>
Wed, 21 Jul 2010 20:32:28 +0000 (14:32 -0600)
committerKevin Wolf <[email protected]>
Mon, 26 Jul 2010 11:39:39 +0000 (13:39 +0200)
Libvirt parses qemu help output to determine qemu features. In particular
it probes for the following: "cache=writethrough|writeback|none". The
addition of the unsafe cache mode was inserted within this string, as
opposed to being added to the end, which impacted libvirt's probe.
Unbreak libvirt by keeping the existing cache modes intact and add
unsafe to the end.

This problem only manifests itself if a caching mode is explicitly
specified in the libvirt xml, in which case older syntax for caching is
passed to qemu, which it  no longer understands.

Signed-off-by: Bruce Rogers <[email protected]>
Signed-off-by: Kevin Wolf <[email protected]>
qemu-options.hx

index 0d7dd90710b7f03e8dcaf8e774188a21e19119ef..9ecc54e6ed038308f6aac997de8e996a4c2556d4 100644 (file)
@@ -118,7 +118,7 @@ ETEXI
 DEF("drive", HAS_ARG, QEMU_OPTION_drive,
     "-drive [file=file][,if=type][,bus=n][,unit=m][,media=d][,index=i]\n"
     "       [,cyls=c,heads=h,secs=s[,trans=t]][,snapshot=on|off]\n"
-    "       [,cache=writethrough|writeback|unsafe|none][,format=f]\n"
+    "       [,cache=writethrough|writeback|none|unsafe][,format=f]\n"
     "       [,serial=s][,addr=A][,id=name][,aio=threads|native]\n"
     "       [,readonly=on|off]\n"
     "                use 'file' as a drive image\n", QEMU_ARCH_ALL)
This page took 0.028773 seconds and 4 git commands to generate.