]> Git Repo - qemu.git/commitdiff
iotests: 185: prepare for backup over block-copy
authorVladimir Sementsov-Ogievskiy <[email protected]>
Sat, 16 Jan 2021 21:46:54 +0000 (00:46 +0300)
committerMax Reitz <[email protected]>
Tue, 26 Jan 2021 13:36:37 +0000 (14:36 +0100)
The further change of moving backup to be a one block-copy call will
make copying chunk-size and cluster-size two separate things. So, even
with 64k cluster sized qcow2 image, default chunk would be 1M.
185 test however assumes, that with speed limited to 64K, one iteration
would result in offset=64K. It will change, as first iteration would
result in offset=1M independently of speed.

So, let's explicitly specify, what test wants: set max-chunk to 64K, so
that one iteration is 64K. Note, that we don't need to limit
max-workers, as block-copy rate limiter will handle the situation and
wouldn't start new workers when speed limit is obviously reached.

Signed-off-by: Vladimir Sementsov-Ogievskiy <[email protected]>
Reviewed-by: Max Reitz <[email protected]>
Message-Id: <20210116214705[email protected]>
Signed-off-by: Max Reitz <[email protected]>
tests/qemu-iotests/185
tests/qemu-iotests/185.out

index 7bc8fe5767a3fee97c1ce7f2bfe5d824f27a6b0a..f2ec5c5cebf8eb2c3f04acf19ca0ab4a9e9ce3ab 100755 (executable)
@@ -183,7 +183,8 @@ _send_qemu_cmd $h \
                       'target': '$TEST_IMG.copy',
                       'format': '$IMGFMT',
                       'sync': 'full',
-                      'speed': 65536 } }" \
+                      'speed': 65536,
+                      'x-perf': {'max-chunk': 65536} } }" \
     "return"
 
 # If we don't sleep here 'quit' command races with disk I/O
index eab55d22bf207624dba390a1c0bc47fb56434bf0..9dedc8eacbedf1fa820f098acefa88406270611e 100644 (file)
@@ -88,7 +88,8 @@ Formatting 'TEST_DIR/t.qcow2.copy', fmt=qcow2 cluster_size=65536 extended_l2=off
                       'target': 'TEST_DIR/t.IMGFMT.copy',
                       'format': 'IMGFMT',
                       'sync': 'full',
-                      'speed': 65536 } }
+                      'speed': 65536,
+                      'x-perf': { 'max-chunk': 65536 } } }
 Formatting 'TEST_DIR/t.qcow2.copy', fmt=qcow2 cluster_size=65536 extended_l2=off compression_type=zlib size=67108864 lazy_refcounts=off refcount_bits=16
 {"timestamp": {"seconds":  TIMESTAMP, "microseconds":  TIMESTAMP}, "event": "JOB_STATUS_CHANGE", "data": {"status": "created", "id": "disk"}}
 {"timestamp": {"seconds":  TIMESTAMP, "microseconds":  TIMESTAMP}, "event": "JOB_STATUS_CHANGE", "data": {"status": "running", "id": "disk"}}
This page took 0.030226 seconds and 4 git commands to generate.