]> Git Repo - qemu.git/commitdiff
arm/translate-a64: mark path as unreachable to eliminate warning
authorEmilio G. Cota <[email protected]>
Mon, 13 Nov 2017 13:55:24 +0000 (13:55 +0000)
committerPeter Maydell <[email protected]>
Mon, 13 Nov 2017 13:55:24 +0000 (13:55 +0000)
Fixes the following warning when compiling with gcc 5.4.0 with -O1
optimizations and --enable-debug:

target/arm/translate-a64.c: In function ‘aarch64_tr_translate_insn’:
target/arm/translate-a64.c:2361:8: error: ‘post_index’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
     if (!post_index) {
        ^
target/arm/translate-a64.c:2307:10: note: ‘post_index’ was declared here
     bool post_index;
          ^
target/arm/translate-a64.c:2386:8: error: ‘writeback’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
     if (writeback) {
        ^
target/arm/translate-a64.c:2308:10: note: ‘writeback’ was declared here
     bool writeback;
          ^

Note that idx comes from selecting 2 bits, and therefore its value
can be at most 3.

Signed-off-by: Emilio G. Cota <[email protected]>
Acked-by: Philippe Mathieu-Daudé <[email protected]>
Message-id: 1510087611[email protected]
Reviewed-by: Peter Maydell <[email protected]>
Signed-off-by: Peter Maydell <[email protected]>
target/arm/translate-a64.c

index caca05aa41c4d188b99fd43100956d897610abc8..625ef2dfd23bc3179a416e54cf14d577f96bb31d 100644 (file)
@@ -2351,6 +2351,8 @@ static void disas_ldst_reg_imm9(DisasContext *s, uint32_t insn,
         post_index = false;
         writeback = true;
         break;
+    default:
+        g_assert_not_reached();
     }
 
     if (rn == 31) {
This page took 0.037452 seconds and 4 git commands to generate.