]> Git Repo - qemu.git/commitdiff
qdev-monitor: set DeviceState opts before calling realize
authorBandan Das <[email protected]>
Wed, 26 Feb 2014 17:32:40 +0000 (10:32 -0700)
committerAlex Williamson <[email protected]>
Wed, 26 Feb 2014 17:32:40 +0000 (10:32 -0700)
Setting opts before the realize property is set allows the
following patch to make decisions based on whether the user
specified "rombar". This also avoids having to create a new
tristate property especially for this purpose

Reviewed-by: Andreas Färber <[email protected]>
Signed-off-by: Bandan Das <[email protected]>
Signed-off-by: Alex Williamson <[email protected]>
qdev-monitor.c

index 3a7dc0d428abb6ce890c29c0c312378666a8f202..6673e3cb6187e9c7062863a91eaff871d993f00b 100644 (file)
@@ -548,16 +548,18 @@ DeviceState *qdev_device_add(QemuOpts *opts)
                                   OBJECT(dev), NULL);
         g_free(name);
     }
+
+    dev->opts = opts;
     object_property_set_bool(OBJECT(dev), true, "realized", &err);
     if (err != NULL) {
         qerror_report_err(err);
         error_free(err);
+        dev->opts = NULL;
         object_unparent(OBJECT(dev));
         object_unref(OBJECT(dev));
         qerror_report(QERR_DEVICE_INIT_FAILED, driver);
         return NULL;
     }
-    dev->opts = opts;
     return dev;
 }
 
This page took 0.027367 seconds and 4 git commands to generate.