target-ppc: Document TOCTTOU in hugepage support

The code to find the minimum page size is is vulnerable to TOCTTOU.
Added in commit 2d103aa "target-ppc: fix hugepage support when using
memory-backend-file" (v2.4.0).  Since I can't fix it myself right now,
add a FIXME comment.

Cc: Paolo Bonzini <[email protected]>
Cc: Michael Roth <[email protected]>
Signed-off-by: Markus Armbruster <[email protected]>
Message-Id: <1458066895[email protected]>
Reviewed-by: Marc-André Lureau <[email protected]>

diff --git a/target-ppc/kvm.c b/target-ppc/kvm.c
index 776336b8b44711fc75f60d158f326cfbb0d22d27..2fc993143e98d9943a42c67548294980f5431c3d 100644 (file)
--- a/target-ppc/kvm.c
+++ b/target-ppc/kvm.c
@@ -333,6 +333,12 @@ static long gethugepagesize(const char *mem_path)
     return fs.f_bsize;
 }
 
+/*
+ * FIXME TOCTTOU: this iterates over memory backends' mem-path, which
+ * may or may not name the same files / on the same filesystem now as
+ * when we actually open and map them.  Iterate over the file
+ * descriptors instead, and use qemu_fd_getpagesize().
+ */
 static int find_max_supported_pagesize(Object *obj, void *opaque)
 {
     char *mem_path;