]> Git Repo - qemu.git/commitdiff
qapi-visit.py: Clean up a sloppy use of field prefix
authorMarkus Armbruster <[email protected]>
Wed, 7 May 2014 07:53:49 +0000 (09:53 +0200)
committerLuiz Capitulino <[email protected]>
Thu, 15 May 2014 18:00:46 +0000 (14:00 -0400)
generate_visit_struct_fields() generates the base type's struct member
name both with and without the field prefix.  Harmless, because the
field prefix is always empty there: only unboxed complex members have
a prefix, and those can't have a base type.

Clean it up anyway.

Signed-off-by: Markus Armbruster <[email protected]>
Reviewed-by: Eric Blake <[email protected]>
Signed-off-by: Luiz Capitulino <[email protected]>
scripts/qapi-visit.py

index 57be9bf00c5b0f70e9ec1623c3271fae4f9f6f8f..1e368bedbbbe73cdf0497e08571ee92e9a5e32ae 100644 (file)
@@ -60,7 +60,7 @@ static void visit_type_%(full_name)s_fields(Visitor *m, %(name)s ** obj, Error *
 
     if base:
         ret += mcgen('''
-visit_start_implicit_struct(m, (void**) &(*obj)->%(c_name)s, sizeof(%(type)s), &err);
+visit_start_implicit_struct(m, (void**) &(*obj)->%(c_prefix)s%(c_name)s, sizeof(%(type)s), &err);
 if (!err) {
     visit_type_%(type)s_fields(m, &(*obj)->%(c_prefix)s%(c_name)s, &err);
     error_propagate(errp, err);
This page took 0.02863 seconds and 4 git commands to generate.