]> Git Repo - qemu.git/commitdiff
qapi: Use qapi_enum_parse() in input_type_enum()
authorMarkus Armbruster <[email protected]>
Thu, 24 Aug 2017 08:46:05 +0000 (10:46 +0200)
committerMarkus Armbruster <[email protected]>
Mon, 4 Sep 2017 11:09:13 +0000 (13:09 +0200)
Signed-off-by: Markus Armbruster <[email protected]>
Message-Id: <1503564371[email protected]>
Reviewed-by: Marc-AndrĂ© Lureau <[email protected]>
qapi/qapi-visit-core.c

index ed6d2af462420885cccda3507f0c204f2a5ca1e0..ec83ff68f99dd2e3bffe70592748dbd92eaea961 100644 (file)
@@ -14,6 +14,7 @@
 
 #include "qemu/osdep.h"
 #include "qapi/error.h"
+#include "qapi/util.h"
 #include "qemu-common.h"
 #include "qapi/qmp/qobject.h"
 #include "qapi/qmp/qerror.h"
@@ -353,7 +354,7 @@ static void input_type_enum(Visitor *v, const char *name, int *obj,
                             const char *const strings[], Error **errp)
 {
     Error *local_err = NULL;
-    int64_t value = 0;
+    int64_t value;
     char *enum_str;
 
     visit_type_str(v, name, &enum_str, &local_err);
@@ -362,14 +363,8 @@ static void input_type_enum(Visitor *v, const char *name, int *obj,
         return;
     }
 
-    while (strings[value] != NULL) {
-        if (strcmp(strings[value], enum_str) == 0) {
-            break;
-        }
-        value++;
-    }
-
-    if (strings[value] == NULL) {
+    value = qapi_enum_parse(strings, enum_str, -1, NULL);
+    if (value < 0) {
         error_setg(errp, QERR_INVALID_PARAMETER, enum_str);
         g_free(enum_str);
         return;
This page took 0.026813 seconds and 4 git commands to generate.