vpc: Fail open on bad header checksum

vpc_open() merely prints a warning when it finds a bad header
checksum.  Turn that into a hard error.

Cc: Kevin Wolf <[email protected]>
Signed-off-by: Markus Armbruster <[email protected]>
Message-Id: <20181017082702[email protected]>
[Error message capitalized for local consistency]
Reviewed-by: Kevin Wolf <[email protected]>

diff --git a/block/vpc.c b/block/vpc.c
index bf294abfa7d202970d2485f235d4d99e15b6349c..984187cadd0b445f08cf6c45831bec6b8f97ba37 100644 (file)
--- a/block/vpc.c
+++ b/block/vpc.c
@@ -284,9 +284,11 @@ static int vpc_open(BlockDriverState *bs, QDict *options, int flags,
 
     checksum = be32_to_cpu(footer->checksum);
     footer->checksum = 0;
-    if (vpc_checksum(s->footer_buf, HEADER_SIZE) != checksum)
-        fprintf(stderr, "block-vpc: The header checksum of '%s' is "
-            "incorrect.\n", bs->filename);
+    if (vpc_checksum(s->footer_buf, HEADER_SIZE) != checksum) {
+        error_setg(errp, "Incorrect header checksum");
+        ret = -EINVAL;
+        goto fail;
+    }
 
     /* Write 'checksum' back to footer, or else will leave it with zero. */
     footer->checksum = cpu_to_be32(checksum);