]> Git Repo - qemu.git/commit
hw/arm/musicpal: Don't connect two qemu_irqs directly to the same input
authorPhilippe Mathieu-Daudé <[email protected]>
Sat, 7 Nov 2020 19:34:02 +0000 (20:34 +0100)
committerPeter Maydell <[email protected]>
Tue, 10 Nov 2020 11:03:48 +0000 (11:03 +0000)
commit498661dd22a1b60461e41d256a7197fea3c4ff0e
tree0d69ccb773d282ea929b6b789f963f7b9bf9be88
parentbdad3654d3c55f478e538037d9eccd204e5fc8ee
hw/arm/musicpal: Don't connect two qemu_irqs directly to the same input

The MusicPal board code connects both of the IRQ outputs of the UART
to the same INTC qemu_irq. Connecting two qemu_irqs outputs directly
to the same input is not valid as it produces subtly wrong behaviour
(for instance if both the IRQ lines are high, and then one goes
low, the INTC input will see this as a high-to-low transition
even though the second IRQ line should still be holding it high).

This kind of wiring needs an explicitly created OR gate; add one.

Inspired-by: Peter Maydell <[email protected]>
Signed-off-by: Philippe Mathieu-Daudé <[email protected]>
Message-id: 20201107193403[email protected]
Reviewed-by: Peter Maydell <[email protected]>
Signed-off-by: Peter Maydell <[email protected]>
hw/arm/Kconfig
hw/arm/musicpal.c
This page took 0.025679 seconds and 4 git commands to generate.