]> Git Repo - linux.git/commit
kernfs: fix memleak in kernel_ops_readdir()
authorAndrea Arcangeli <[email protected]>
Mon, 5 Aug 2019 17:34:04 +0000 (10:34 -0700)
committerGreg Kroah-Hartman <[email protected]>
Mon, 5 Aug 2019 18:34:11 +0000 (20:34 +0200)
commitcc798c83898ea0a77fcaa1a92afda35c3c3ded74
tree8e292bb12576c6411fd06256d9c1df25f0a6fe96
parentac43432cb1f5c2950408534987e57c2071e24d8f
kernfs: fix memleak in kernel_ops_readdir()

If getdents64 is killed or hits on segfault, it'll leave cgroups
directories in sysfs pinned leaking memory because the kernfs node
won't be freed on rmdir and the parent neither.

Repro:

  # for i in `seq 1000`; do mkdir $i; done
  # rmdir *
  # for i in `seq 1000`; do mkdir $i; done
  # rmdir *

  # for i in `seq 1000`; do while :; do ls $i/ >/dev/null; done & done
  # while :; do killall ls; done

  kernfs_node_cache in /proc/slabinfo keeps going up as expected.

Signed-off-by: Andrea Arcangeli <[email protected]>
Signed-off-by: Tejun Heo <[email protected]>
Cc: [email protected] # goes way back to original sysfs days
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Greg Kroah-Hartman <[email protected]>
fs/kernfs/dir.c
This page took 0.043684 seconds and 4 git commands to generate.