]> Git Repo - linux.git/commitdiff
timers: Invoke timer_start_debug() where it makes sense
authorThomas Gleixner <[email protected]>
Fri, 22 Dec 2017 14:51:14 +0000 (15:51 +0100)
committerThomas Gleixner <[email protected]>
Fri, 29 Dec 2017 22:13:10 +0000 (23:13 +0100)
The timer start debug function is called before the proper timer base is
set. As a consequence the trace data contains the stale CPU and flags
values.

Call the debug function after setting the new base and flags.

Fixes: 500462a9de65 ("timers: Switch to a non-cascading wheel")
Signed-off-by: Thomas Gleixner <[email protected]>
Cc: Peter Zijlstra <[email protected]>
Cc: Frederic Weisbecker <[email protected]>
Cc: Sebastian Siewior <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: Paul McKenney <[email protected]>
Cc: Anna-Maria Gleixner <[email protected]>
Link: https://lkml.kernel.org/r/[email protected]
kernel/time/timer.c

index 6be576e0220957b2d8e3c166a06bd9f802555a78..89a9e1b4264a07a9a6d69e37759c27ced8b4de37 100644 (file)
@@ -1007,8 +1007,6 @@ __mod_timer(struct timer_list *timer, unsigned long expires, unsigned int option
        if (!ret && (options & MOD_TIMER_PENDING_ONLY))
                goto out_unlock;
 
-       debug_activate(timer, expires);
-
        new_base = get_target_base(base, timer->flags);
 
        if (base != new_base) {
@@ -1032,6 +1030,8 @@ __mod_timer(struct timer_list *timer, unsigned long expires, unsigned int option
                }
        }
 
+       debug_activate(timer, expires);
+
        timer->expires = expires;
        /*
         * If 'idx' was calculated above and the base time did not advance
This page took 0.057598 seconds and 4 git commands to generate.