]> Git Repo - linux.git/commitdiff
wifi: wilc1000: use correct sequence of RESET for chip Power-UP/Down
authorAjay Singh <[email protected]>
Tue, 24 May 2022 12:06:19 +0000 (12:06 +0000)
committerKalle Valo <[email protected]>
Mon, 30 May 2022 11:18:00 +0000 (14:18 +0300)
For power-up sequence, WILC expects RESET set to high 5ms after making
chip_en(enable) so corrected chip power-up sequence by making RESET high.
For Power-Down sequence, the correct sequence make RESET and CHIP_EN low
without any extra delay.

Fixes: ec031ac4792c ("wilc1000: Add reset/enable GPIO support to SPI driver")
Signed-off-by: Ajay Singh <[email protected]>
Signed-off-by: Kalle Valo <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
drivers/net/wireless/microchip/wilc1000/spi.c

index 18420e954402f12dd790bab23423a075e3cba825..2ae8dd3411aca758c48d0f64e8a52777bcda1c73 100644 (file)
@@ -191,11 +191,11 @@ static void wilc_wlan_power(struct wilc *wilc, bool on)
                /* assert ENABLE: */
                gpiod_set_value(gpios->enable, 1);
                mdelay(5);
-               /* deassert RESET: */
-               gpiod_set_value(gpios->reset, 0);
-       } else {
                /* assert RESET: */
                gpiod_set_value(gpios->reset, 1);
+       } else {
+               /* deassert RESET: */
+               gpiod_set_value(gpios->reset, 0);
                /* deassert ENABLE: */
                gpiod_set_value(gpios->enable, 0);
        }
This page took 0.066801 seconds and 4 git commands to generate.