]> Git Repo - linux.git/commitdiff
rpmsg: glink: Release driver_override
authorBjorn Andersson <[email protected]>
Mon, 9 Jan 2023 22:39:31 +0000 (14:39 -0800)
committerBjorn Andersson <[email protected]>
Wed, 15 Feb 2023 15:46:02 +0000 (07:46 -0800)
Upon termination of the rpmsg_device, driver_override needs to be freed
to avoid leaking the potentially assigned string.

Fixes: 42cd402b8fd4 ("rpmsg: Fix kfree() of static memory on setting driver_override")
Fixes: 39e47767ec9b ("rpmsg: Add driver_override device attribute for rpmsg_device")
Reviewed-by: Chris Lew <[email protected]>
Signed-off-by: Bjorn Andersson <[email protected]>
Signed-off-by: Bjorn Andersson <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
drivers/rpmsg/qcom_glink_native.c

index b6c60bf86009b5f7b0b77d955294e1b2af12466e..01d2805fe30f5ead9bf75c236f7d555a38424dee 100644 (file)
@@ -1455,6 +1455,7 @@ static void qcom_glink_rpdev_release(struct device *dev)
 {
        struct rpmsg_device *rpdev = to_rpmsg_device(dev);
 
+       kfree(rpdev->driver_override);
        kfree(rpdev);
 }
 
@@ -1698,6 +1699,7 @@ static void qcom_glink_device_release(struct device *dev)
 
        /* Release qcom_glink_alloc_channel() reference */
        kref_put(&channel->refcount, qcom_glink_channel_release);
+       kfree(rpdev->driver_override);
        kfree(rpdev);
 }
 
This page took 0.065458 seconds and 4 git commands to generate.