drm/panel-edp: Avoid adding multiple preferred modes

If a non generic edp-panel is under aux-bus, the mode read from edid would
still be selected as preferred and results in multiple preferred modes,
which is ambiguous.

If both hard-coded mode and edid exists, only add mode from hard-coded.

Signed-off-by: Hsin-Yi Wang <[email protected]>
Reviewed-by: Douglas Anderson <[email protected]>
Signed-off-by: Douglas Anderson <[email protected]>
Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]

diff --git a/drivers/gpu/drm/panel/panel-edp.c b/drivers/gpu/drm/panel/panel-edp.c
index 3e144145a6bd32ba7c8fe8d1163664d823c8f123..825fa2a0d8a530f396cce8209d869342b5a73647 100644 (file)
--- a/drivers/gpu/drm/panel/panel-edp.c
+++ b/drivers/gpu/drm/panel/panel-edp.c
@@ -589,6 +589,7 @@ static int panel_edp_get_modes(struct drm_panel *panel,
 {
        struct panel_edp *p = to_panel_edp(panel);
        int num = 0;
+       bool has_hard_coded_modes = p->desc->num_timings || p->desc->num_modes;
        bool has_override_edid_mode = p->detected_panel &&
                                      p->detected_panel != ERR_PTR(-EINVAL) &&
                                      p->detected_panel->override_edid_mode;
@@ -599,7 +600,11 @@ static int panel_edp_get_modes(struct drm_panel *panel,
 
                if (!p->edid)
                        p->edid = drm_get_edid(connector, p->ddc);
-               if (p->edid) {
+               /*
+                * If both edid and hard-coded modes exists, skip edid modes to
+                * avoid multiple preferred modes.
+                */
+               if (p->edid && !has_hard_coded_modes) {
                        if (has_override_edid_mode) {
                                /*
                                 * override_edid_mode is specified. Use
@@ -616,12 +621,7 @@ static int panel_edp_get_modes(struct drm_panel *panel,
                pm_runtime_put_autosuspend(panel->dev);
        }
 
-       /*
-        * Add hard-coded panel modes. Don't call this if there are no timings
-        * and no modes (the generic edp-panel case) because it will clobber
-        * the display_info that was already set by drm_add_edid_modes().
-        */
-       if (p->desc->num_timings || p->desc->num_modes)
+       if (has_hard_coded_modes)
                num += panel_edp_get_non_edid_modes(p, connector);
        else if (!num)
                dev_warn(p->base.dev, "No display modes\n");