orangefs: fix a oob in orangefs_debug_write

I got a syzbot report: slab-out-of-bounds Read in
orangefs_debug_write... several people suggested fixes,
I tested Al Viro's suggestion and made this patch.

Signed-off-by: Mike Marshall <[email protected]>
Reported-by: [email protected]

diff --git a/fs/orangefs/orangefs-debugfs.c b/fs/orangefs/orangefs-debugfs.c
index 1b508f5433846e8b759be4dd34c6d4c5b30e1ac8..fa41db08848802780eecc7b0fcabfc5a8444b874 100644 (file)
--- a/fs/orangefs/orangefs-debugfs.c
+++ b/fs/orangefs/orangefs-debugfs.c
@@ -393,9 +393,9 @@ static ssize_t orangefs_debug_write(struct file *file,
         * Thwart users who try to jamb a ridiculous number
         * of bytes into the debug file...
         */
-       if (count > ORANGEFS_MAX_DEBUG_STRING_LEN + 1) {
+       if (count > ORANGEFS_MAX_DEBUG_STRING_LEN) {
                silly = count;
-               count = ORANGEFS_MAX_DEBUG_STRING_LEN + 1;
+               count = ORANGEFS_MAX_DEBUG_STRING_LEN;
        }
 
        buf = kzalloc(ORANGEFS_MAX_DEBUG_STRING_LEN, GFP_KERNEL);