x86/microcode/core: Return an error only when necessary

Return an error from the late loading function which is run on each CPU
only when an error has actually been encountered during the update.

Signed-off-by: Borislav Petkov (AMD) <[email protected]>
Link: https://lore.kernel.org/r/[email protected]

diff --git a/arch/x86/kernel/cpu/microcode/core.c b/arch/x86/kernel/cpu/microcode/core.c
index ddc0958428a50a2323b35e66c353dff6b8ec31ed..7a329e5613544b078231bf66d3f2c318aaf035d6 100644 (file)
--- a/arch/x86/kernel/cpu/microcode/core.c
+++ b/arch/x86/kernel/cpu/microcode/core.c
@@ -409,10 +409,10 @@ static int __reload_late(void *info)
                goto wait_for_siblings;
 
        if (err >= UCODE_NFOUND) {
-               if (err == UCODE_ERROR)
+               if (err == UCODE_ERROR) {
                        pr_warn("Error reloading microcode on CPU %d\n", cpu);
-
-               ret = -1;
+                       ret = -1;
+               }
        }
 
 wait_for_siblings: