HID: hid-sensor-custom: Fix big on-stack allocation in hid_sensor_custom_get_known()

struct hid_sensor_custom_properties is currently 384 bytes big, which consumes
too much stack space for no good reason. Make it dynamically allocated.

Fixes: 98c062e824519 ("HID: hid-sensor-custom: Allow more custom iio sensors")
Reported-by: kernel test robot <[email protected]>
Signed-off-by: Jiri Kosina <[email protected]>

diff --git a/drivers/hid/hid-sensor-custom.c b/drivers/hid/hid-sensor-custom.c
index 0c287dde345c80762395fa43fe2e0bda30d6acfd..3e3f89e01d819bb30b2eb30c36adc1d0ba89df42 100644 (file)
--- a/drivers/hid/hid-sensor-custom.c
+++ b/drivers/hid/hid-sensor-custom.c
@@ -911,21 +911,28 @@ hid_sensor_custom_get_known(struct hid_sensor_hub_device *hsdev,
        int ret;
        const struct hid_sensor_custom_match *match =
                hid_sensor_custom_known_table;
        int ret;
        const struct hid_sensor_custom_match *match =
                hid_sensor_custom_known_table;

-       struct hid_sensor_custom_properties prop;
+       struct hid_sensor_custom_properties *prop;

 
 

-       ret = hid_sensor_custom_properties_get(hsdev, &prop);
+       prop = kmalloc(sizeof(struct hid_sensor_custom_properties), GFP_KERNEL);
+       if (!prop)
+               return -ENOMEM;
+
+       ret = hid_sensor_custom_properties_get(hsdev, prop);

        if (ret < 0)
        if (ret < 0)

-               return ret;
+               goto out;

 
        while (match->tag) {
 
        while (match->tag) {

-               if (hid_sensor_custom_do_match(hsdev, match, &prop)) {
+               if (hid_sensor_custom_do_match(hsdev, match, prop)) {

                        *known = match;
                        *known = match;

-                       return 0;
+                       ret = 0;
+                       goto out;

                }
                match++;
        }
                }
                match++;
        }

-
-       return -ENODATA;
+       ret = -ENODATA;
+out:
+       kfree(prop);
+       return ret;

 }
 
 static struct platform_device *
 }
 
 static struct platform_device *