]> Git Repo - linux.git/commitdiff
cxl/mbox: Add debug messages for enabled mailbox commands
authorRobert Richter <[email protected]>
Wed, 25 Jan 2023 08:57:28 +0000 (09:57 +0100)
committerDan Williams <[email protected]>
Thu, 26 Jan 2023 23:57:30 +0000 (15:57 -0800)
Only unsupported mailbox commands are reported in debug messages. A
list of enabled commands is useful too. Change debug messages to also
report the opcodes of enabled commands. Esp. if card initialization
fails there is no way to get this information from userland.

On that occasion also add missing trailing newlines.

Signed-off-by: Robert Richter <[email protected]>
Reviewed-by: Alison Schofield <[email protected]>
Reviewed-by: Jonathan Cameron <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Dan Williams <[email protected]>
drivers/cxl/core/mbox.c

index b03fba21279931661b5bebcc4a330058bb00625e..cae43cea00cd565c3f5e4e5555d392a64b237ba8 100644 (file)
@@ -610,11 +610,12 @@ static void cxl_walk_cel(struct cxl_dev_state *cxlds, size_t size, u8 *cel)
 
                if (!cmd) {
                        dev_dbg(cxlds->dev,
-                               "Opcode 0x%04x unsupported by driver", opcode);
+                               "Opcode 0x%04x unsupported by driver\n", opcode);
                        continue;
                }
 
                set_bit(cmd->info.id, cxlds->enabled_cmds);
+               dev_dbg(cxlds->dev, "Opcode 0x%04x enabled\n", opcode);
        }
 }
 
This page took 0.047407 seconds and 4 git commands to generate.