]> Git Repo - linux.git/commitdiff
ARM: 8519/1: ICST: try other dividends than 1
authorLinus Walleij <[email protected]>
Wed, 10 Feb 2016 08:25:17 +0000 (09:25 +0100)
committerRussell King <[email protected]>
Thu, 11 Feb 2016 14:12:33 +0000 (14:12 +0000)
Since the dawn of time the ICST code has only supported divide
by one or hang in an eternal loop. Luckily we were always dividing
by one because the reference frequency for the systems using
the ICSTs is 24MHz and the [min,max] values for the PLL input
if [10,320] MHz for ICST307 and [6,200] for ICST525, so the loop
will always terminate immediately without assigning any divisor
for the reference frequency.

But for the code to make sense, let's insert the missing i++

Reported-by: David Binderman <[email protected]>
Cc: [email protected]
Signed-off-by: Linus Walleij <[email protected]>
Signed-off-by: Russell King <[email protected]>
arch/arm/common/icst.c

index d3c0e69df2591fc8597325919972da4361079ce4..d7ed252708c57fa86cff5d51887bd756b53b48e7 100644 (file)
@@ -62,6 +62,7 @@ icst_hz_to_vco(const struct icst_params *p, unsigned long freq)
 
                if (f > p->vco_min && f <= p->vco_max)
                        break;
+               i++;
        } while (i < 8);
 
        if (i >= 8)
This page took 0.061395 seconds and 4 git commands to generate.