LSM: fix return value check in safesetid_init_securityfs()

In case of error, the function securityfs_create_dir() returns ERR_PTR()
and never returns NULL. The NULL test in the return value check should
be replaced with IS_ERR().

Fixes: aeca4e2ca65c ("LSM: add SafeSetID module that gates setid calls")
Signed-off-by: Wei Yongjun <[email protected]>
Acked-by: Kees Cook <[email protected]>
Signed-off-by: James Morris <[email protected]>

diff --git a/security/safesetid/securityfs.c b/security/safesetid/securityfs.c
index 61be4ee459cc23120ed47630f9cfb4491ab7391a..2c6c829be044dd70032c50039084ad984e4dc87a 100644 (file)
--- a/security/safesetid/securityfs.c
+++ b/security/safesetid/securityfs.c
@@ -167,7 +167,7 @@ static int __init safesetid_init_securityfs(void)
                return 0;
 
        safesetid_policy_dir = securityfs_create_dir("safesetid", NULL);
-       if (!safesetid_policy_dir) {
+       if (IS_ERR(safesetid_policy_dir)) {
                ret = PTR_ERR(safesetid_policy_dir);
                goto error;
        }