kunit: Fix the wrong kfree of copy for kunit_filter_suites()

If the outer layer for loop is iterated more than once and it fails not
in the first iteration, the copy pointer has been moved. So it should free
the original copy's backup copy_start.

Fixes: abbf73816b6f ("kunit: fix possible memory leak in kunit_filter_suites()")
Signed-off-by: Jinjie Ruan <[email protected]>
Reviewed-by: Rae Moar <[email protected]>
Reviewed-by: David Gow <[email protected]>
Signed-off-by: Shuah Khan <[email protected]>

diff --git a/lib/kunit/executor.c b/lib/kunit/executor.c
index a037a46fae5ea7cc75cfe7d03dc77fce3eb21392..9358ed2df839512b85e252b23ed562d3ad250b75 100644 (file)
--- a/lib/kunit/executor.c
+++ b/lib/kunit/executor.c
@@ -243,7 +243,7 @@ free_parsed_glob:
 
 free_copy:
        if (*err)
-               kfree(copy);
+               kfree(copy_start);
 
        return filtered;
 }