clk: microchip: check for null return of devm_kzalloc()

Because of the possible failure of devm_kzalloc(), name might be NULL and
will cause null pointer dereference later.

Therefore, it might be better to check it and directly return -ENOMEM.

Fixes: d39fb172760e ("clk: microchip: add PolarFire SoC fabric clock support")
Signed-off-by: Hui Tang <[email protected]>
Reviewed-by: Conor Dooley <[email protected]>
[claudiu.beznea: s/refrence/reference/, s/possilble/possible]
Signed-off-by: Claudiu Beznea <[email protected]>
Link: https://lore.kernel.org/r/[email protected]

diff --git a/drivers/clk/microchip/clk-mpfs-ccc.c b/drivers/clk/microchip/clk-mpfs-ccc.c
index 7be028dced63d352c039e40128f6da89d6b31d28..32aae880a14f3b1c582ce7031dc4bb8bc032eb8e 100644 (file)
--- a/drivers/clk/microchip/clk-mpfs-ccc.c
+++ b/drivers/clk/microchip/clk-mpfs-ccc.c
@@ -166,6 +166,9 @@ static int mpfs_ccc_register_outputs(struct device *dev, struct mpfs_ccc_out_hw_
                struct mpfs_ccc_out_hw_clock *out_hw = &out_hws[i];
                char *name = devm_kzalloc(dev, 23, GFP_KERNEL);
 
+               if (!name)
+                       return -ENOMEM;
+
                snprintf(name, 23, "%s_out%u", parent->name, i);
                out_hw->divider.hw.init = CLK_HW_INIT_HW(name, &parent->hw, &clk_divider_ops, 0);
                out_hw->divider.reg = data->pll_base[i / MPFS_CCC_OUTPUTS_PER_PLL] +
@@ -200,6 +203,9 @@ static int mpfs_ccc_register_plls(struct device *dev, struct mpfs_ccc_pll_hw_clo
                struct mpfs_ccc_pll_hw_clock *pll_hw = &pll_hws[i];
                char *name = devm_kzalloc(dev, 18, GFP_KERNEL);
 
+               if (!name)
+                       return -ENOMEM;
+
                pll_hw->base = data->pll_base[i];
                snprintf(name, 18, "ccc%s_pll%u", strchrnul(dev->of_node->full_name, '@'), i);
                pll_hw->name = (const char *)name;