rtc: rtc-rs5c372: fix up NULL name in transfer error path

rs5c_get_regs() currently uses rs5c->rtc->name for its debug printk when
i2c_transfer() fails, though it is used several times before the rtc dev
has been registered. The earliest we can get at the symbolic name is via
the i2c client's struct device, which can be handled by moving the first
rs5c_get_regs() until after the client pointer is assigned.

Signed-off-by: Paul Mundt <[email protected]>
Cc: David Brownell <[email protected]>
Cc: Alessandro Zummo <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>

diff --git a/drivers/rtc/rtc-rs5c372.c b/drivers/rtc/rtc-rs5c372.c
index 6b67b50979278df5c790ed2b950841e9843af621..67d8768c1b64a7a8ab11f80c7a6fa6927f08c7f3 100644 (file)
--- a/drivers/rtc/rtc-rs5c372.c
+++ b/drivers/rtc/rtc-rs5c372.c
@@ -99,7 +99,7 @@ static int rs5c_get_regs(struct rs5c372 *rs5c)
         * least 80219 chips; this works around that bug.
         */
        if ((i2c_transfer(client->adapter, msgs, 1)) != 1) {
-               pr_debug("%s: can't read registers\n", rs5c->rtc->name);
+               dev_warn(&client->dev, "can't read registers\n");
                return -EIO;
        }
 
@@ -512,12 +512,12 @@ static int rs5c372_probe(struct i2c_client *client)
                goto exit;
        }
 
-       /* we read registers 0x0f then 0x00-0x0f; skip the first one */
-       rs5c372->regs=&rs5c372->buf[1];
-
        rs5c372->client = client;
        i2c_set_clientdata(client, rs5c372);
 
+       /* we read registers 0x0f then 0x00-0x0f; skip the first one */
+       rs5c372->regs = &rs5c372->buf[1];
+
        err = rs5c_get_regs(rs5c372);
        if (err < 0)
                goto exit_kfree;