ubifs: mount_ubifs: Release authentication resource in error handling path

Release the authentication related resource in some error handling
branches in mount_ubifs().

Signed-off-by: Zhihao Cheng <[email protected]>
Cc: <[email protected]>  # 4.20+
Fixes: d8a22773a12c6d7 ("ubifs: Enable authentication support")
Reviewed-by: Sascha Hauer <[email protected]>
Signed-off-by: Richard Weinberger <[email protected]>

diff --git a/fs/ubifs/super.c b/fs/ubifs/super.c
index 9796f5df2f7ff560c6a72966f07aa962b81e1fd3..732218ef665678c7901489ae8578bea278a44d04 100644 (file)
--- a/fs/ubifs/super.c
+++ b/fs/ubifs/super.c
@@ -1331,7 +1331,7 @@ static int mount_ubifs(struct ubifs_info *c)
 
        err = ubifs_read_superblock(c);
        if (err)
-               goto out_free;
+               goto out_auth;
 
        c->probing = 0;
 
@@ -1343,18 +1343,18 @@ static int mount_ubifs(struct ubifs_info *c)
                ubifs_err(c, "'compressor \"%s\" is not compiled in",
                          ubifs_compr_name(c, c->default_compr));
                err = -ENOTSUPP;
-               goto out_free;
+               goto out_auth;
        }
 
        err = init_constants_sb(c);
        if (err)
-               goto out_free;
+               goto out_auth;
 
        sz = ALIGN(c->max_idx_node_sz, c->min_io_size) * 2;
        c->cbuf = kmalloc(sz, GFP_NOFS);
        if (!c->cbuf) {
                err = -ENOMEM;
-               goto out_free;
+               goto out_auth;
        }
 
        err = alloc_wbufs(c);
@@ -1629,6 +1629,8 @@ out_wbufs:
        free_wbufs(c);
 out_cbuf:
        kfree(c->cbuf);
+out_auth:
+       ubifs_exit_authentication(c);
 out_free:
        kfree(c->write_reserve_buf);
        kfree(c->bu.buf);