ASoC: rsnd: return -EIO if rsnd_dmaen_request_channel() failed

PTR_ERR(NULL) is success. Normally when a function returns both NULL
and error pointers, it means that NULL is not a error.
But, rsnd_dmaen_request_channel() returns NULL if requested resource
was failed.
Let's return -EIO if rsnd_dmaen_request_channel() was failed on
rsnd_dmaen_nolock_start().
This patch fixes commit edce5c496c6a ("ASoC: rsnd: Request/Release DMA
channel eachtime")

Reported-by: Dan Carpenter <[email protected]>
Signed-off-by: Kuninori Morimoto <[email protected]>
Signed-off-by: Mark Brown <[email protected]>

diff --git a/sound/soc/sh/rcar/dma.c b/sound/soc/sh/rcar/dma.c
index 5bc9ec16813cb26b16d229def97e65f86b15a9b6..fd557abfe390a1ea6c6800e9e9836d039bdbcee3 100644 (file)
--- a/sound/soc/sh/rcar/dma.c
+++ b/sound/soc/sh/rcar/dma.c
@@ -219,11 +219,9 @@ static int rsnd_dmaen_nolock_start(struct rsnd_mod *mod,
                                                 dma->mod_from,
                                                 dma->mod_to);
        if (IS_ERR_OR_NULL(dmaen->chan)) {
-               int ret = PTR_ERR(dmaen->chan);
-
                dmaen->chan = NULL;
                dev_err(dev, "can't get dma channel\n");
-               return ret;
+               return -EIO;
        }
 
        return 0;