rcuscale: Remove redundant WARN_ON_ONCE() splat

There are two places where WARN_ON_ONCE() is called two times
in the error paths. One which is encapsulated into if() condition
and another one, which is unnecessary, is placed in the brackets.

Remove an extra WARN_ON_ONCE() splat which is in brackets.

Reviewed-by: Paul E. McKenney <[email protected]>
Reviewed-by: Neeraj Upadhyay <[email protected]>
Signed-off-by: Uladzislau Rezki (Sony) <[email protected]>
Signed-off-by: Frederic Weisbecker <[email protected]>

diff --git a/kernel/rcu/rcuscale.c b/kernel/rcu/rcuscale.c
index d360fa44b234db3a2285da0466f76d55c903b3e5..0f3059b1b80d03ddb8884fa4352e9497f476eecf 100644 (file)
--- a/kernel/rcu/rcuscale.c
+++ b/kernel/rcu/rcuscale.c
@@ -889,14 +889,12 @@ kfree_scale_init(void)
 
                if (WARN_ON_ONCE(jiffies_at_lazy_cb - jif_start < 2 * HZ)) {
                        pr_alert("ERROR: call_rcu() CBs are not being lazy as expected!\n");
-                       WARN_ON_ONCE(1);
                        firsterr = -1;
                        goto unwind;
                }
 
                if (WARN_ON_ONCE(jiffies_at_lazy_cb - jif_start > 3 * HZ)) {
                        pr_alert("ERROR: call_rcu() CBs are being too lazy!\n");
-                       WARN_ON_ONCE(1);
                        firsterr = -1;
                        goto unwind;
                }