]> Git Repo - linux.git/commitdiff
drm/tiny: correctly print `struct resource *` on error
authorJoey Gouly <[email protected]>
Tue, 10 Oct 2023 17:46:52 +0000 (18:46 +0100)
committerThomas Zimmermann <[email protected]>
Thu, 12 Oct 2023 08:57:07 +0000 (10:57 +0200)
The `res` variable is already a `struct resource *`, don't take the address of it.

Fixes incorrect output:

simple-framebuffer 9e20dc000.framebuffer: [drm] *ERROR* could not acquire memory range [??? 0xffff4be88a387d00-0xfffffefffde0a240 flags 0x0]: -16

To be correct:

simple-framebuffer 9e20dc000.framebuffer: [drm] *ERROR* could not acquire memory range [mem 0x9e20dc000-0x9e307bfff flags 0x200]: -16

Signed-off-by: Joey Gouly <[email protected]>
Fixes: 9a10c7e6519b ("drm/simpledrm: Add support for system memory framebuffers")
Cc: Thomas Zimmermann <[email protected]>
Cc: Thierry Reding <[email protected]>
Cc: Javier Martinez Canillas <[email protected]>
Cc: [email protected]
Cc: <[email protected]> # v6.3+
Reviewed-by: Thomas Zimmermann <[email protected]>
Signed-off-by: Thomas Zimmermann <[email protected]>
Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
drivers/gpu/drm/tiny/simpledrm.c

index ff86ba1ae1b8b07b609b7e5567f3400d34c79010..8ea120eb8674bd41f48b4405cb784d87d356eeba 100644 (file)
@@ -745,7 +745,7 @@ static struct simpledrm_device *simpledrm_device_create(struct drm_driver *drv,
 
                ret = devm_aperture_acquire_from_firmware(dev, res->start, resource_size(res));
                if (ret) {
-                       drm_err(dev, "could not acquire memory range %pr: %d\n", &res, ret);
+                       drm_err(dev, "could not acquire memory range %pr: %d\n", res, ret);
                        return ERR_PTR(ret);
                }
 
This page took 0.075278 seconds and 4 git commands to generate.