media: atomisp: add a notice about possible leak resources

Calling acpi_bus_get_device() may end allocating resources that
aren't freed. So, add a notice about that, as, if those drivers
get out of staging, we may need some changes.

Fixes: 0d64e9420583 ("media: atomisp: Add some ACPI detection info")
Signed-off-by: Mauro Carvalho Chehab <[email protected]>

diff --git a/drivers/staging/media/atomisp/i2c/atomisp-gc0310.c b/drivers/staging/media/atomisp/i2c/atomisp-gc0310.c
index b69a5b50e3bce46c59ad117883b7ec8785764257..ad1bd7d6a02b0e63d45b64767a6c35ccb84bef36 100644 (file)
--- a/drivers/staging/media/atomisp/i2c/atomisp-gc0310.c
+++ b/drivers/staging/media/atomisp/i2c/atomisp-gc0310.c
@@ -1317,9 +1317,10 @@ static int gc0310_probe(struct i2c_client *client)
                dev_err(&client->dev, "Error could not get ACPI device\n");
                return -ENODEV;
        }
-
        pr_info("%s: ACPI detected it on bus ID=%s, HID=%s\n",
                __func__, acpi_device_bid(adev), acpi_device_hid(adev));
+       // FIXME: may need to release resources allocated by acpi_bus_get_device()
+
 
        dev = kzalloc(sizeof(*dev), GFP_KERNEL);
        if (!dev)

diff --git a/drivers/staging/media/atomisp/i2c/atomisp-gc2235.c b/drivers/staging/media/atomisp/i2c/atomisp-gc2235.c
index e863e19f266959313ac4f22853441d5384deb97f..a12dd0e858bc1d3f8ab79057f0f2f63b9dc8e542 100644 (file)
--- a/drivers/staging/media/atomisp/i2c/atomisp-gc2235.c
+++ b/drivers/staging/media/atomisp/i2c/atomisp-gc2235.c
@@ -1059,9 +1059,9 @@ static int gc2235_probe(struct i2c_client *client)
                dev_err(&client->dev, "Error could not get ACPI device\n");
                return -ENODEV;
        }
-
        pr_info("%s: ACPI detected it on bus ID=%s, HID=%s\n",
                __func__, acpi_device_bid(adev), acpi_device_hid(adev));
+       // FIXME: may need to release resources allocated by acpi_bus_get_device()
 
        dev = kzalloc(sizeof(*dev), GFP_KERNEL);
        if (!dev)

diff --git a/drivers/staging/media/atomisp/i2c/atomisp-lm3554.c b/drivers/staging/media/atomisp/i2c/atomisp-lm3554.c
index 0e9f80239dcbc00463ffa28370d39f2ef93ca99b..a899145265ffe001c691e501a2903d24e758f37b 100644 (file)
--- a/drivers/staging/media/atomisp/i2c/atomisp-lm3554.c
+++ b/drivers/staging/media/atomisp/i2c/atomisp-lm3554.c
@@ -858,9 +858,9 @@ static int lm3554_probe(struct i2c_client *client)
                dev_err(&client->dev, "Error could not get ACPI device\n");
                return -ENODEV;
        }
-
        pr_info("%s: ACPI detected it on bus ID=%s, HID=%s\n",
                __func__, acpi_device_bid(adev), acpi_device_hid(adev));
+       // FIXME: may need to release resources allocated by acpi_bus_get_device()
 
        flash = kzalloc(sizeof(*flash), GFP_KERNEL);
        if (!flash)

diff --git a/drivers/staging/media/atomisp/i2c/atomisp-mt9m114.c b/drivers/staging/media/atomisp/i2c/atomisp-mt9m114.c
index e7af4bbd844b2b9adee968a5bb51885535ebb88a..ac61b391e3f91e1161e3411fa79ab193692e0d94 100644 (file)
--- a/drivers/staging/media/atomisp/i2c/atomisp-mt9m114.c
+++ b/drivers/staging/media/atomisp/i2c/atomisp-mt9m114.c
@@ -1824,9 +1824,9 @@ static int mt9m114_probe(struct i2c_client *client)
                dev_err(&client->dev, "Error could not get ACPI device\n");
                return -ENODEV;
        }
-
        pr_info("%s: ACPI detected it on bus ID=%s, HID=%s\n",
                __func__, acpi_device_bid(adev), acpi_device_hid(adev));
+       // FIXME: may need to release resources allocated by acpi_bus_get_device()
 
        /* Setup sensor configuration structure */
        dev = kzalloc(sizeof(*dev), GFP_KERNEL);

diff --git a/drivers/staging/media/atomisp/i2c/atomisp-ov2680.c b/drivers/staging/media/atomisp/i2c/atomisp-ov2680.c
index 334f23f35d4a8180c830be1c076c6679df6244b6..1b60f6a9c0e0e3c56d7b28d092651c57116dfe87 100644 (file)
--- a/drivers/staging/media/atomisp/i2c/atomisp-ov2680.c
+++ b/drivers/staging/media/atomisp/i2c/atomisp-ov2680.c
@@ -1251,9 +1251,9 @@ static int ov2680_probe(struct i2c_client *client)
                dev_err(&client->dev, "Error could not get ACPI device\n");
                return -ENODEV;
        }
-
        dev_info(&client->dev, "%s: ACPI detected it on bus ID=%s, HID=%s\n",
                __func__, acpi_device_bid(adev), acpi_device_hid(adev));
+       // FIXME: may need to release resources allocated by acpi_bus_get_device()
 
        dev = kzalloc(sizeof(*dev), GFP_KERNEL);
        if (!dev)

diff --git a/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c b/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c
index 08799054704a2845dd17538b4b158b6e8897e57c..718d10f89d5a10ff0e75c935b751628d3b01ec2c 100644 (file)
--- a/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c
+++ b/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c
@@ -1222,9 +1222,9 @@ static int ov2722_probe(struct i2c_client *client)
                dev_err(&client->dev, "Error could not get ACPI device\n");
                return -ENODEV;
        }
-
        pr_info("%s: ACPI detected it on bus ID=%s, HID=%s\n",
                __func__, acpi_device_bid(adev), acpi_device_hid(adev));
+       // FIXME: may need to release resources allocated by acpi_bus_get_device()
 
        dev = kzalloc(sizeof(*dev), GFP_KERNEL);
        if (!dev)

diff --git a/drivers/staging/media/atomisp/i2c/ov5693/atomisp-ov5693.c b/drivers/staging/media/atomisp/i2c/ov5693/atomisp-ov5693.c
index 886f9fd0152f16e49de24c00147e0a4860ccfd09..2be0ef14d53e1445eb9d37a3b6dbf12e2f781157 100644 (file)
--- a/drivers/staging/media/atomisp/i2c/ov5693/atomisp-ov5693.c
+++ b/drivers/staging/media/atomisp/i2c/ov5693/atomisp-ov5693.c
@@ -1909,9 +1909,9 @@ static int ov5693_probe(struct i2c_client *client)
                dev_err(&client->dev, "Error could not get ACPI device\n");
                return -ENODEV;
        }
-
        pr_info("%s: ACPI detected it on bus ID=%s, HID=%s\n",
                __func__, acpi_device_bid(adev), acpi_device_hid(adev));
+       // FIXME: may need to release resources allocated by acpi_bus_get_device()
 
        /*
         * Firmware workaround: Some modules use a "secondary default"