]> Git Repo - linux.git/commitdiff
applicom.c: fix apparently-broken code in do_ac_read()
authorAndrew Morton <[email protected]>
Thu, 16 Oct 2008 05:04:18 +0000 (22:04 -0700)
committerLinus Torvalds <[email protected]>
Thu, 16 Oct 2008 18:21:47 +0000 (11:21 -0700)
The code scriblles over a local pointer whereas it appears to be trying
to write to the memory at which that pointer points.

Addresses http://bugzilla.kernel.org/show_bug.cgi?id=11397

Nobody we know can test this change.

Reported-by: Zvonimir Rakamaric <[email protected]>
Cc: Jesse Barnes <[email protected]>
Cc: David Woodhouse <[email protected]>
Cc: Jiri Slaby <[email protected]>
Cc: Alan Cox <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
drivers/char/applicom.c

index b899d9182c7dec0b0b03e2857b680a30806cf12e..05674febb0c6bff218d2c76373402e7fcf0e1f58 100644 (file)
@@ -478,7 +478,7 @@ static int do_ac_read(int IndexCard, char __user *buf,
                struct st_ram_io *st_loc, struct mailbox *mailbox)
 {
        void __iomem *from = apbs[IndexCard].RamIO + RAM_TO_PC;
-       unsigned char *to = (unsigned char *)&mailbox;
+       unsigned char *to = (unsigned char *)mailbox;
 #ifdef DEBUG
        int c;
 #endif
This page took 0.055756 seconds and 4 git commands to generate.