]> Git Repo - linux.git/commitdiff
ASoC: SOF: ipc4-topology: Print queue IDs in error
authorRanjani Sridharan <[email protected]>
Thu, 9 Feb 2023 14:21:22 +0000 (16:21 +0200)
committerMark Brown <[email protected]>
Thu, 9 Feb 2023 14:31:16 +0000 (14:31 +0000)
Print the queue ID's during bind/unbind errors as well to make it easier
to see what failed exactly.

Signed-off-by: Ranjani Sridharan <[email protected]>
Reviewed-by: Péter Ujfalusi <[email protected]>
Reviewed-by: Pierre-Louis Bossart <[email protected]>
Signed-off-by: Peter Ujfalusi <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Mark Brown <[email protected]>
sound/soc/sof/ipc4-topology.c

index 43340c8917b7f7c4641e5f86ae93819d4f837301..02ddc48a1107960bf6ef8dc084a96d4f28305030 100644 (file)
@@ -1790,8 +1790,9 @@ static int sof_ipc4_route_setup(struct snd_sof_dev *sdev, struct snd_sof_route *
 
        ret = sof_ipc_tx_message(sdev->ipc, &msg, 0, NULL, 0);
        if (ret < 0) {
-               dev_err(sdev->dev, "%s: failed to bind modules %s -> %s\n",
-                       __func__, src_widget->widget->name, sink_widget->widget->name);
+               dev_err(sdev->dev, "failed to bind modules %s:%d -> %s:%d\n",
+                       src_widget->widget->name, sroute->src_queue_id,
+                       sink_widget->widget->name, sroute->dst_queue_id);
 
                sof_ipc4_put_queue_id(src_widget, sroute->src_queue_id,
                                      SOF_PIN_TYPE_SOURCE);
@@ -1839,8 +1840,9 @@ static int sof_ipc4_route_free(struct snd_sof_dev *sdev, struct snd_sof_route *s
 
        ret = sof_ipc_tx_message(sdev->ipc, &msg, 0, NULL, 0);
        if (ret < 0)
-               dev_err(sdev->dev, "failed to unbind modules %s -> %s\n",
-                       src_widget->widget->name, sink_widget->widget->name);
+               dev_err(sdev->dev, "failed to unbind modules %s:%d -> %s:%d\n",
+                       src_widget->widget->name, sroute->src_queue_id,
+                       sink_widget->widget->name, sroute->dst_queue_id);
 out:
        sof_ipc4_put_queue_id(sink_widget, sroute->dst_queue_id, SOF_PIN_TYPE_SINK);
        sof_ipc4_put_queue_id(src_widget, sroute->src_queue_id, SOF_PIN_TYPE_SOURCE);
This page took 0.060811 seconds and 4 git commands to generate.