]> Git Repo - linux.git/commitdiff
HID: hyperv: fix possible memory leak in mousevsc_probe()
authorYang Yingliang <[email protected]>
Fri, 28 Oct 2022 13:40:43 +0000 (21:40 +0800)
committerJiri Kosina <[email protected]>
Wed, 2 Nov 2022 13:34:56 +0000 (14:34 +0100)
If hid_add_device() returns error, it should call hid_destroy_device()
to free hid_dev which is allocated in hid_allocate_device().

Fixes: 74c4fb058083 ("HID: hv_mouse: Properly add the hid device")
Signed-off-by: Yang Yingliang <[email protected]>
Reviewed-by: Wei Liu <[email protected]>
Signed-off-by: Jiri Kosina <[email protected]>
drivers/hid/hid-hyperv.c

index e0bc731241960dc1bec7c837227d88768226b83f..ab57b49a44ed966962ccf49dc9218c899c23ccf0 100644 (file)
@@ -499,7 +499,7 @@ static int mousevsc_probe(struct hv_device *device,
 
        ret = hid_add_device(hid_dev);
        if (ret)
-               goto probe_err1;
+               goto probe_err2;
 
 
        ret = hid_parse(hid_dev);
This page took 0.057156 seconds and 4 git commands to generate.