]> Git Repo - linux.git/commitdiff
phy: qcom-snps: Correct the FSEL_MASK
authorSandeep Maheswaram <[email protected]>
Mon, 25 Oct 2021 04:19:35 +0000 (09:49 +0530)
committerVinod Koul <[email protected]>
Tue, 26 Oct 2021 11:06:23 +0000 (16:36 +0530)
The FSEL_MASK which selects the refclock is defined incorrectly.
It should be [4:6] not [5:7]. Due to this incorrect definition, the BIT(7)
in USB2_PHY_USB_PHY_HS_PHY_CTRL_COMMON0 is reset which keeps PHY analog
blocks ON during suspend.
Fix this issue by correctly defining the FSEL_MASK.

Fixes: 51e8114f80d0 ("phy: qcom-snps: Add SNPS USB PHY driver for QCOM based SOCs")
Signed-off-by: Sandeep Maheswaram <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Vinod Koul <[email protected]>
drivers/phy/qualcomm/phy-qcom-snps-femto-v2.c

index ae4bac024c7b1e69a622fec1af737dff0dbbd048..7e61202aa234ed8c95ff1bdf36fc36f9cadbae31 100644 (file)
@@ -33,7 +33,7 @@
 
 #define USB2_PHY_USB_PHY_HS_PHY_CTRL_COMMON0   (0x54)
 #define RETENABLEN                             BIT(3)
-#define FSEL_MASK                              GENMASK(7, 5)
+#define FSEL_MASK                              GENMASK(6, 4)
 #define FSEL_DEFAULT                           (0x3 << 4)
 
 #define USB2_PHY_USB_PHY_HS_PHY_CTRL_COMMON1   (0x58)
This page took 0.067624 seconds and 4 git commands to generate.